codope commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1806388549
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -205,38 +205,40 @@ public HoodieMetadataPayload(Option<GenericRecord>
recordOpt) {
}
protected HoodieMetadataPayload(String key, int type, Map<String,
HoodieMetadataFileInfo> filesystemMetadata) {
- this(key, type, filesystemMetadata, null, null, null, null);
+ this(key, type, filesystemMetadata, null, null, null, null,
+ filesystemMetadata.isEmpty());
Review Comment:
Unfortunately this is not going to work as `isDeletedRecord` for
filesystemMetadata is at the level of `HoodieMetadataFileInfo`. Even if all
files were to be deleted, the filesystemMetadata map is not going to be empty,
instead it is going to have HoodieMetadataFileInfos with isDeleted set to true.
I think `files` partition is very critical. How about we leave this
constructor as is and introduce new constructor which instantiates
isDeletedRecord for all other metadata payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
