jonvex commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1806834326
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/BaseSparkInternalRowReaderContext.java:
##########
@@ -49,8 +52,18 @@
public abstract class BaseSparkInternalRowReaderContext extends
HoodieReaderContext<InternalRow> {
@Override
- public HoodieRecordMerger getRecordMerger(String mergerStrategy) {
- return HoodieSparkRecordMerger.getRecordMerger(mergerStrategy);
+ public Option<HoodieRecordMerger> getRecordMerger(RecordMergeMode mergeMode,
String mergerStrategy, String mergerImpls) {
+ // TODO(HUDI-7843):
+ // get rid of event time and overwrite with latest. Just return
Option.empty
+ switch (mergeMode) {
+ case EVENT_TIME_ORDERING:
+ return Option.of(new DefaultSparkRecordMerger());
+ case OVERWRITE_WITH_LATEST:
+ return Option.of(new OverwriteWithLatestSparkRecordMerger());
+ case CUSTOM:
+ default:
+ return Option.of(HoodieRecordUtils.createRecordMerger(null,
EngineType.SPARK, mergerImpls, mergerStrategy));
Review Comment:
It doesn't go through this logic currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
