jonvex commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1806987565
##########
hudi-common/src/main/java/org/apache/hudi/common/engine/HoodieReaderContext.java:
##########
@@ -55,7 +57,7 @@ public abstract class HoodieReaderContext<T> {
private HoodieFileGroupReaderSchemaHandler<T> schemaHandler = null;
private String tablePath = null;
private String latestCommitTime = null;
- private HoodieRecordMerger recordMerger = null;
+ private Option<HoodieRecordMerger> recordMerger = null;
Review Comment:
We want to make sure it is set. If we get an npe then we know there is a
bug. If we have it as option.empty then it is possible that the bug will happen
silently and cause correctness issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
