linliu-code commented on code in PR #12122:
URL: https://github.com/apache/hudi/pull/12122#discussion_r1807204089
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieMergedLogRecordScanner.java:
##########
@@ -99,7 +101,14 @@ protected <T> void processNextRecord(HoodieRecord<T>
newRecord) throws IOExcepti
// NOTE: Record have to be cloned here to make sure if it holds
low-level engine-specific
// payload pointing into a shared, mutable (underlying) buffer
we get a clean copy of
// it since these records will be put into records(Map).
- records.put(key, latestHoodieRecord.copy());
+ HoodieRecord finalRecord = latestHoodieRecord.copy();
+
+ // Reserve the delete information.
+ if (prevRecord.isDelete(readerSchema, this.getPayloadProps())
Review Comment:
Checked the code logic. For fg, the payload properties are derived from
table properties. For non-fg, the payload only contain one filed precombined
field. I have updated the code to add table properties initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]