yihua commented on code in PR #12127:
URL: https://github.com/apache/hudi/pull/12127#discussion_r1807445869
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -537,27 +537,41 @@ private Pair<Integer, HoodieData<HoodieRecord>>
initializeBloomFiltersPartition(
return Pair.of(fileGroupCount, records);
}
- protected abstract HoodieData<HoodieRecord>
getFunctionalIndexRecords(List<Pair<String, FileSlice>> partitionFileSlicePairs,
+ protected abstract HoodieData<HoodieRecord>
getFunctionalIndexRecords(List<Pair<String, Pair<String, Long>>>
partitionFilePathPairs,
Review Comment:
Could we rename `partitionFilePathPairs` to contain size or use
`StoragePathInfo` instead of `Pair<String, Long>` to maintain the readability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
