[
https://issues.apache.org/jira/browse/HUDI-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17194109#comment-17194109
]
Pratyaksh Sharma commented on HUDI-1029:
----------------------------------------
We don't use SimpleDateFormat in TimestampBasedKeyGenerator now. Looks like
this Jira is no more valid.
> Use FastDateFormat for parsing and formating in TimestampBasedKeyGenerator
> ----------------------------------------------------------------------------
>
> Key: HUDI-1029
> URL: https://issues.apache.org/jira/browse/HUDI-1029
> Project: Apache Hudi
> Issue Type: Improvement
> Components: DeltaStreamer
> Reporter: steven zhang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.2
>
>
> 1. in TimestampBasedKeyGenerator#getKey method, generate a HoodieKey will
> create a new SimpleDateFormat object,the dateformat object can be reused as
> class variable.
> 2. SimpleDateFormat is not thread safe,there is always potential thread safe
> problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
