yihua commented on code in PR #12127:
URL: https://github.com/apache/hudi/pull/12127#discussion_r1809627336
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -537,27 +537,41 @@ private Pair<Integer, HoodieData<HoodieRecord>>
initializeBloomFiltersPartition(
return Pair.of(fileGroupCount, records);
}
- protected abstract HoodieData<HoodieRecord>
getFunctionalIndexRecords(List<Pair<String, FileSlice>> partitionFileSlicePairs,
+ protected abstract HoodieData<HoodieRecord>
getFunctionalIndexRecords(List<Pair<String, Pair<String, Long>>>
partitionFilePathAndSizeTriplet,
Review Comment:
nit: Use `Triple` instead of `Pair<String, Pair<String, Long>>`. Let's fix
it in a follow-up.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -570,6 +584,9 @@ private HoodieIndexDefinition
getFunctionalIndexDefinition(String indexName) {
}
private Set<String> getIndexPartitionsToInit(MetadataPartitionType
partitionType) {
+ if (dataMetaClient.getIndexMetadata().isEmpty()) {
Review Comment:
The name is confusing while I was reading the code:
`dataMetaClient.getIndexMetadata()` seems to indicate that this is for all
index metadata, but it is only for functional and secondary index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
