jonvex commented on code in PR #12122:
URL: https://github.com/apache/hudi/pull/12122#discussion_r1809642555
##########
hudi-common/src/main/java/org/apache/hudi/common/model/DeleteRecord.java:
##########
@@ -88,6 +88,13 @@ public Comparable<?> getOrderingValue() {
return orderingVal;
}
+ public Comparable<?> getOrderingVal(Comparable<?> defaultVal) {
+ if (orderingVal == null) {
Review Comment:
I guess if someone overrides getOrderingValue(). But it's probably fine to
leave it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
