geserdugarov commented on code in PR #12120:
URL: https://github.com/apache/hudi/pull/12120#discussion_r1809893164
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -61,13 +60,11 @@ public static List<String> getHashKeys(HoodieKey hoodieKey,
String indexKeyField
}
protected static List<String> getHashKeys(String recordKey, String
indexKeyFields) {
- return !recordKey.contains(":") ? Collections.singletonList(recordKey) :
Review Comment:
Checks like this are moved in one place,
`KeyGenUtil::extractRecordKeysByFields`, and fixed by check both `:` and `,` to
decide is it a complex key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
