zhangyue19921010 commented on code in PR #12136:
URL: https://github.com/apache/hudi/pull/12136#discussion_r1810001323
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/HoodieRowDataCreateHandle.java:
##########
@@ -142,7 +143,11 @@ public void write(String recordKey, String partitionPath,
RowData record) throws
? HoodieRecordDelegate.create(recordKey, partitionPath, null,
newRecordLocation) : null;
writeStatus.markSuccess(recordDelegate, Option.empty());
} catch (Throwable t) {
+ LOG.error("Failed to write : key is " + recordKey + ", data is " +
rowData, t);
writeStatus.markFailure(recordKey, partitionPath, t);
Review Comment:
like `HoodieCreateHandle` the same logic contains in `doWrite` function. And
`FlinkCreateHandle` didn't overwrite this `doWrite` function yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
