[ 
https://issues.apache.org/jira/browse/HUDI-8417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Y Ethan Guo updated HUDI-8417:
------------------------------
    Description: 
[https://github.com/apache/hudi/pull/11943#discussion_r1805545250]

The HoodieReaderContext has the following API which takes 
`Option<HoodieRecordMerger>`.  By design, the merge implementation class should 
always be non-empty.  So we need to see if changing the argument type to 
`HoodieRecordMerger` incurs any error.
{code:java}
public void setRecordMerger(Option<HoodieRecordMerger> recordMerger) {
  this.recordMerger = recordMerger;
}{code}

  was:
[https://github.com/apache/hudi/pull/11943#discussion_r1805545250]

The Hoo


> Revisit setRecordMerger API in HoodieReaderContext
> --------------------------------------------------
>
>                 Key: HUDI-8417
>                 URL: https://issues.apache.org/jira/browse/HUDI-8417
>             Project: Apache Hudi
>          Issue Type: Improvement
>            Reporter: Y Ethan Guo
>            Priority: Major
>             Fix For: 1.1.0
>
>
> [https://github.com/apache/hudi/pull/11943#discussion_r1805545250]
> The HoodieReaderContext has the following API which takes 
> `Option<HoodieRecordMerger>`.  By design, the merge implementation class 
> should always be non-empty.  So we need to see if changing the argument type 
> to `HoodieRecordMerger` incurs any error.
> {code:java}
> public void setRecordMerger(Option<HoodieRecordMerger> recordMerger) {
>   this.recordMerger = recordMerger;
> }{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to