yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1811989665
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -104,10 +98,9 @@ public HoodieFileGroupReader(HoodieReaderContext<T>
readerContext,
this.props = props;
this.start = start;
this.length = length;
- this.recordMergeMode = getRecordMergeMode(props);
HoodieTableConfig tableConfig = hoodieTableMetaClient.getTableConfig();
- this.recordMerger =
readerContext.getRecordMerger(tableConfig.getRecordMergerStrategy());
- readerContext.setRecordMerger(this.recordMerger);
+
readerContext.setRecordMerger(readerContext.getRecordMerger(tableConfig.getRecordMergeMode(),
+ tableConfig.getRecordMergerStrategy(),
props.getString("hoodie.datasource.write.record.merger.impl","")));
Review Comment:
HUDI-8170 for improving the reader context APIs. The config references are
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
