[
https://issues.apache.org/jira/browse/HUDI-8426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Y Ethan Guo updated HUDI-8426:
------------------------------
Description:
[https://github.com/apache/hudi/pull/11943#discussion_r1809691906]
Every config key goes through shouldIgnoreConfig check. For config keys that
do not require checks, we should just exclude them from "params" first.
{code:java}
params.foreach { case (key, value) =>
if (!shouldIgnoreConfig(key, value, params)) {
val existingValue = getStringFromTableConfigWithAlternatives(tableConfig,
key)
if (null != existingValue && !resolver(existingValue, value)) {
diffConfigs.append(s"$key:\t$value\t${tableConfig.getString(key)}\n")
}
}
} {code}
> Optimize shouldIgnoreConfig check in HoodieWriterUtils
> ------------------------------------------------------
>
> Key: HUDI-8426
> URL: https://issues.apache.org/jira/browse/HUDI-8426
> Project: Apache Hudi
> Issue Type: Improvement
> Reporter: Y Ethan Guo
> Priority: Major
> Fix For: 1.1.0
>
>
> [https://github.com/apache/hudi/pull/11943#discussion_r1809691906]
> Every config key goes through shouldIgnoreConfig check. For config keys that
> do not require checks, we should just exclude them from "params" first.
> {code:java}
> params.foreach { case (key, value) =>
> if (!shouldIgnoreConfig(key, value, params)) {
> val existingValue = getStringFromTableConfigWithAlternatives(tableConfig,
> key)
> if (null != existingValue && !resolver(existingValue, value)) {
> diffConfigs.append(s"$key:\t$value\t${tableConfig.getString(key)}\n")
> }
> }
> } {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
