danny0405 commented on code in PR #12150:
URL: https://github.com/apache/hudi/pull/12150#discussion_r1814727416
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieWriteHandle.java:
##########
@@ -174,6 +174,16 @@ protected void doWrite(HoodieRecord record, Schema schema,
TypedProperties props
// NO_OP
}
+ /**
+ * ignore failed write based on 'getIgnoreWriteFailed' config
+ * @param throwable
+ */
+ protected void ignoreWriteFailed(Throwable throwable) {
+ if (config.getIgnoreWriteFailed()) {
+ throw new HoodieException(throwable.getMessage(), throwable);
Review Comment:
Why we throw exception when 'ignore.write.failed' is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
