nsivabalan commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1817966484


##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieUnMergedLogRecordScanner.java:
##########
@@ -83,7 +83,7 @@ protected <T> void processNextRecord(HoodieRecord<T> 
hoodieRecord) throws Except
 
   @Override
   protected void processNextDeletedRecord(DeleteRecord deleteRecord) {
-    throw new IllegalStateException("Not expected to see delete records in 
this log-scan mode. Check Job Config");
+    // no - op

Review Comment:
   There is no consumer of delete record keys at the moment for 
HoodieUnMergedLogRecordScanner. I would prefer to defer this until we have a 
real necessity. When there is a demand, we will anyways add the functionality. 
I have created a follow up https://issues.apache.org/jira/browse/HUDI-8444 
anyways. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to