danny0405 commented on code in PR #12171:
URL: https://github.com/apache/hudi/pull/12171#discussion_r1818636192
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieLogBlock.java:
##########
@@ -271,9 +271,25 @@ public static byte[]
getLogMetadataBytes(Map<HeaderMetadataType, String> metadat
}
/**
- * Convert bytes to LogMetadata, follow the same order as {@link
HoodieLogBlock#getLogMetadataBytes}.
+ * Convert footer metadata to bytes 1. Write size of metadata 2. Write enum
ordinal 3. Write actual bytes
*/
- public static Map<HeaderMetadataType, String>
getLogMetadata(SeekableDataInputStream dis) throws IOException {
+ public static byte[] getFooterMetadataBytes(Map<FooterMetadataType, String>
metadata) throws IOException {
Review Comment:
The `FooterMetadataType` is empty, is this just a code usage fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
