sathyaprakashg commented on a change in pull request #2012:
URL: https://github.com/apache/hudi/pull/2012#discussion_r487415553
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@n3nash This is the execption we get when we don't add namespace to
reader schema. `org.apache.avro.AvroTypeException: Found
hoodie.source.hoodie_source.height.fixed, expecting fixed`.
This exception is raised because we have namespace in writer schema and not
in reader schema. As per my proposed approach above, if we remove the namespace
from writer schema, then we wouldn't get type exception, because now namespace
does not exist in fixed fields for both writer and reader schema
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@n3nash This is the execption we get when we don't add namespace to
reader schema. `org.apache.avro.AvroTypeException: Found
hoodie.source.hoodie_source.height.fixed, expecting fixed`.
This exception is raised because we have namespace in writer schema and not
in reader schema. As per my proposed approach above, if we remove the namespace
from writer schema, then we wouldn't get type exception, because now namespace
does not exist in fixed fields for both writer and reader schema
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@n3nash This is the execption we get when we don't add namespace to
reader schema. `org.apache.avro.AvroTypeException: Found
hoodie.source.hoodie_source.height.fixed, expecting fixed`.
This exception is raised because we have namespace in writer schema and not
in reader schema. As per my proposed approach above, if we remove the namespace
from writer schema, then we wouldn't get type exception, because now namespace
does not exist in fixed fields for both writer and reader schema
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@n3nash This is the execption we get when we don't add namespace to
reader schema. `org.apache.avro.AvroTypeException: Found
hoodie.source.hoodie_source.height.fixed, expecting fixed`.
This exception is raised because we have namespace in writer schema and not
in reader schema. As per my proposed approach above, if we remove the namespace
from writer schema, then we wouldn't get type exception, because now namespace
does not exist in fixed fields for both writer and reader schema
##########
File path: hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroUtils.java
##########
@@ -127,12 +128,59 @@ public static GenericRecord bytesToAvro(byte[] bytes,
Schema schema) throws IOEx
* Convert serialized bytes back into avro record.
*/
public static GenericRecord bytesToAvro(byte[] bytes, Schema writerSchema,
Schema readerSchema) throws IOException {
Review comment:
@n3nash This is the execption we get when we don't add namespace to
reader schema. `org.apache.avro.AvroTypeException: Found
hoodie.source.hoodie_source.height.fixed, expecting fixed`.
This exception is raised because we have namespace in writer schema and not
in reader schema. As per my proposed approach above, if we remove the namespace
from writer schema, then we wouldn't get type exception, because now namespace
does not exist in fixed fields for both writer and reader schema
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
