jonvex commented on code in PR #12178:
URL: https://github.com/apache/hudi/pull/12178#discussion_r1821548532
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BulkInsertDataInternalWriterHelper.java:
##########
@@ -100,22 +98,25 @@ public BulkInsertDataInternalWriterHelper(HoodieTable
hoodieTable, HoodieWriteCo
this.shouldPreserveHoodieMetadata = shouldPreserveHoodieMetadata;
this.arePartitionRecordsSorted = arePartitionRecordsSorted;
this.fileIdPrefix = UUID.randomUUID().toString();
+ this.shouldDropPartitionColumns = writeConfig.shouldDropPartitionColumns();
Review Comment:
Pulled this out of the loop to reduce recomputation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
