jonvex commented on code in PR #12201:
URL: https://github.com/apache/hudi/pull/12201#discussion_r1829564989
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -314,6 +341,11 @@ object ExpressionPayload {
*/
val PAYLOAD_RECORD_AVRO_SCHEMA = "hoodie.payload.record.schema"
+ /**
+ * Original record payload
+ */
+ val PAYLOAD_ORIGINAL_AVRO_PAYLOAD = "hoodie.payload.original.avro.payload"
Review Comment:
I'm not against any of your suggestions for naming, but it would be
inconsistent with the other configs:
```
/**
* Property for pass the merge-into delete clause condition expression.
*/
val PAYLOAD_DELETE_CONDITION = "hoodie.payload.delete.condition"
/**
* Property for pass the merge-into update clauses' condition and
assignments.
*/
val PAYLOAD_UPDATE_CONDITION_AND_ASSIGNMENTS =
"hoodie.payload.update.condition.assignments"
/**
* Property for pass the merge-into insert clauses' condition and
assignments.
*/
val PAYLOAD_INSERT_CONDITION_AND_ASSIGNMENTS =
"hoodie.payload.insert.condition.assignments"
/**
* Property holding record's original (Avro) schema
*/
val PAYLOAD_RECORD_AVRO_SCHEMA = "hoodie.payload.record.schema"
/**
* Original record payload
*/
val PAYLOAD_ORIGINAL_AVRO_PAYLOAD = "hoodie.payload.original.avro.payload"
/**
* Property associated w/ expected combined schema of the joined records
of the source (incoming batch)
* and target (existing) tables
*/
val PAYLOAD_EXPECTED_COMBINED_SCHEMA = "hoodie.payload.combined.schema"
/**
* Internal property determining whether combined schema should be
validated by [[ExpressionPayload]],
* against the one provide by [[PAYLOAD_EXPECTED_COMBINED_SCHEMA]]
(default is "false")
*/
private[sql] val PAYLOAD_SHOULD_VALIDATE_COMBINED_SCHEMA =
"hoodie.payload.combined.schema.validate"
```
If you think we should change them all, I am in support of that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
