codope commented on code in PR #12214:
URL: https://github.com/apache/hudi/pull/12214#discussion_r1832492417
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java:
##########
@@ -155,7 +156,7 @@ public class HoodieMetadataPayload implements
HoodieRecordPayload<HoodieMetadata
/**
* HoodieMetadata secondary index payload field ids
*/
- public static final String SECONDARY_INDEX_FIELD_RECORD_KEY = "recordKey";
+ public static final String SECONDARY_INDEX_RECORD_KEY_SEPARATOR = "$";
Review Comment:
i was thinking of doing base64 encoding at first but then escaping is just
as efficient. Ran a local
[benchmark](https://gist.github.com/codope/b1c73abed748d77c0b4db974d835f9da),
not much difference between the two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
