danny0405 commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1833542634
##########
hudi-cli/src/main/java/org/apache/hudi/cli/commands/SavepointsCommand.java:
##########
@@ -141,7 +142,8 @@ public String deleteSavepoint(
if (completedInstants.empty()) {
throw new HoodieException("There are no completed savepoint to run
delete");
}
- HoodieInstant savePoint = new HoodieInstant(false,
HoodieTimeline.SAVEPOINT_ACTION, instantTime);
+ InstantFactory instantFactory =
metaClient.getTimelineLayout().getInstantFactory();
+ HoodieInstant savePoint =
instantFactory.createNewInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.SAVEPOINT_ACTION, instantTime);
Review Comment:
same thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
