bvaradar commented on code in PR #11923: URL: https://github.com/apache/hudi/pull/11923#discussion_r1835208730
########## hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/common/InstantComparatorHelper.java: ########## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.timeline.versioning.common; + +import org.apache.hudi.common.table.timeline.HoodieInstant; + +import java.io.Serializable; +import java.util.Comparator; +import java.util.Map; + +/** + * Comparators for HoodieInstant that are also serializable. + * java.util.Comparators are not serializable. + */ +public class InstantComparatorHelper { + + public static class ActionComparator implements Serializable, Comparator<HoodieInstant> { + private final Map<String, String> comparableActions; + + public ActionComparator(Map<String, String> comparableActions) { + this.comparableActions = comparableActions; + } + + @Override + public int compare(HoodieInstant instant1, HoodieInstant instant2) { + String action1 = getComparableAction(instant1.getAction()); + String action2 = getComparableAction(instant2.getAction()); + return action1.compareTo(action2); + } + + private String getComparableAction(String action) { + return comparableActions.getOrDefault(action, action); + } + + } + + public static class TimestampBasedComparator implements Serializable, Comparator<HoodieInstant> { Review Comment: Change to RequestedTimeBasedComparator -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
