codope commented on code in PR #12174:
URL: https://github.com/apache/hudi/pull/12174#discussion_r1837097511


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -503,8 +503,8 @@ private String generateUniqueInstantTime(String 
initializationTime) {
     }
   }
 
-  private Pair<Integer, HoodieData<HoodieRecord>> 
initializePartitionStatsIndex(List<DirectoryInfo> partitionInfoList) {
-    HoodieData<HoodieRecord> records = 
HoodieTableMetadataUtil.convertFilesToPartitionStatsRecords(engineContext, 
partitionInfoList, dataWriteConfig.getMetadataConfig(), dataMetaClient,
+  private Pair<Integer, HoodieData<HoodieRecord>> 
initializePartitionStatsIndex(List<DirectoryInfo> partitionInfoList) throws 
IOException {
+    HoodieData<HoodieRecord> records = 
HoodieTableMetadataUtil.convertFilesToPartitionStatsRecords(engineContext, 
getPartitionFileSlicePairs(), dataWriteConfig.getMetadataConfig(), 
dataMetaClient,

Review Comment:
   Is there a way to get the latest file slices including the ones due to 
current inflight instant? We are not passing HoodieCommitMetadata to 
initializeFromFileSystem, so I guess we ay have to resort to listing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to