nsivabalan commented on code in PR #12174:
URL: https://github.com/apache/hudi/pull/12174#discussion_r1839321040
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -503,8 +493,8 @@ private String generateUniqueInstantTime(String
initializationTime) {
}
}
- private Pair<Integer, HoodieData<HoodieRecord>>
initializePartitionStatsIndex(List<DirectoryInfo> partitionInfoList) {
- HoodieData<HoodieRecord> records =
HoodieTableMetadataUtil.convertFilesToPartitionStatsRecords(engineContext,
partitionInfoList, dataWriteConfig.getMetadataConfig(), dataMetaClient,
+ private Pair<Integer, HoodieData<HoodieRecord>>
initializePartitionStatsIndex(List<DirectoryInfo> partitionInfoList) throws
IOException {
Review Comment:
I am ok to initialize new FSV while we are trying to initialize a new MDT
partition.
but lets not initialize new MDT FSV for regular updates.
for eg, getRecordIndexReplacedRecords() should not be initializing a new MDT
fsv and just re-use existing one.
wdyt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
