satishkotha commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r488345849
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/RocksDbBasedFileSystemView.java
##########
@@ -371,6 +371,47 @@ void
removeBootstrapBaseFileMapping(Stream<BootstrapBaseFileMapping> bootstrapBa
schemaHelper.getPrefixForSliceViewByPartitionFile(partitionPath,
fileId)).map(Pair::getValue)).findFirst());
}
+ @Override
+ protected void resetReplacedFileGroups(final Map<HoodieFileGroupId,
HoodieInstant> replacedFileGroups) {
Review comment:
Yes, we do delete and insert. Definitely, would be helpful to have
someone with more experience review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
