linliu-code opened a new pull request, #12247:
URL: https://github.com/apache/hudi/pull/12247

   
   
   ### Change Logs
   
   Looks like we were not surfacing all errors/failures to the caller. So, 
fixing all such cases in this patch. Added tests w/ both ignoreFailed = false 
and true and validated the cases.
   
   Cases covered:
   
   Partition mis-match: when ignoreFailed = true, throws 
HoodieValidationException to caller. when ignoreFailed = false, validator 
execution may not fail, but caller can get exception via hasValidationFailure() 
and validator.getThrowables().get(0)
   File slice mis-match w/ log files: when ignoreFailed = true, throws 
HoodieValidationException to caller. when ignoreFailed = false, validator 
execution may not fail, but caller can get exception via hasValidationFailure() 
and validator.getThrowables().get(0)
   RLI mis-match (file slices match, but RLI mis-matches): when ignoreFailed = 
true, throws HoodieValidationException to caller. when ignoreFailed = false, 
validator execution may not fail, but caller can get exception via 
hasValidationFailure() and validator.getThrowables().get(0)
   
   ### Impact
   
   Robust MDT validation.
   
   ### Risk level (write none, low medium or high below)
   
   Low.
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, 
config, or user-facing change. If not, put "none"._
   
   - _The config description must be updated if new configs are added or the 
default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. 
Please create a Jira ticket, attach the
     ticket number here and follow the 
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to 
make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to