codope commented on code in PR #12255:
URL: https://github.com/apache/hudi/pull/12255#discussion_r1841555285
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordGlobalLocation.java:
##########
@@ -67,8 +67,7 @@ public boolean equals(Object o) {
HoodieRecordGlobalLocation otherLoc = (HoodieRecordGlobalLocation) o;
return Objects.equals(partitionPath, otherLoc.partitionPath)
&& Objects.equals(instantTime, otherLoc.instantTime)
- && Objects.equals(fileId, otherLoc.fileId)
- && Objects.equals(position, otherLoc.position);
+ && Objects.equals(fileId, otherLoc.fileId);
Review Comment:
are there any side effects wrt positional deletes if we remove position from
equals? Also, don't we need to keep the same fields in hashcode as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
