danny0405 commented on code in PR #12224:
URL: https://github.com/apache/hudi/pull/12224#discussion_r1841733615
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1447,11 +1457,11 @@ protected void tryUpgrade(HoodieTableMetaClient
metaClient, Option<String> insta
tableServiceClient.rollbackFailedWrites(pendingRollbacks, true, true);
}
- new UpgradeDowngrade(metaClient, config, context, upgradeDowngradeHelper)
- .run(HoodieTableVersion.current(), instantTime.orElse(null));
-
metaClient.reloadActiveTimeline();
Review Comment:
Can we just move the timeline reload out of the `tryUpgrade` method and do
it outside, so that we can eliminate the tricks of this atomic reference
get/set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
