bvaradar commented on code in PR #11923:
URL: https://github.com/apache/hudi/pull/11923#discussion_r1844178662
##########
hudi-aws/src/test/java/org/apache/hudi/aws/testutils/GlueTestUtil.java:
##########
@@ -112,7 +112,7 @@ public static void createHoodieTable() throws IOException {
String instantTime = "101";
HoodieCommitMetadata commitMetadata = new HoodieCommitMetadata(false);
- createMetaFile(basePath, HoodieTimeline.makeCommitFileName(instantTime),
commitMetadata);
+ createMetaFile(basePath, new
DefaultInstantFileNameGenerator().makeCommitFileName(instantTime),
commitMetadata);
Review Comment:
The major consideration for this refactoring was to easily drop 0.x support
in later releases. It is not easy to do this piecemeal as dropping this code
requires refactoring too. So, intentionally keeping these setup. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
