nsivabalan commented on code in PR #12263:
URL: https://github.com/apache/hudi/pull/12263#discussion_r1844417117
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1660,7 +1660,10 @@ public static String
deleteMetadataTablePartition(HoodieTableMetaClient dataMeta
* @param index Index of the file group within the partition
* @return The fileID
*/
- public static String getFileIDForFileGroup(MetadataPartitionType
partitionType, int index) {
+ public static String getFileIDForFileGroup(MetadataPartitionType
partitionType, int index, String partitionName) {
Review Comment:
wrt to my comment
https://github.com/apache/hudi/pull/12259/files#r1842787725
I am asking about, why replace "_" with "-".
I was checking the parsing logic for getFileIDForFileGroup(),
getFileGroupIndexFromFileId, and I don't think its strictly requires to replace
"_".
so, was just curious.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -192,6 +192,27 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
Seq(s"cde${SECONDARY_INDEX_RECORD_KEY_SEPARATOR}row2"),
Seq(s"def${SECONDARY_INDEX_RECORD_KEY_SEPARATOR}row3")
)
+ // update the secondary key column after creating multiple secondary
indexes
+ spark.sql(s"update $tableName set not_record_key_col = 'xyz' where
record_key_col = 'row1'")
+ // validate the secondary index records themselves
+ checkAnswer(s"select key, SecondaryIndexMetadata.isDeleted from
hudi_metadata('$basePath') where type=7")(
Review Comment:
I suggested to read the hoodie_partition meta column as well here and ensure
we validate record values in diff secondary indexes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
