yihua commented on code in PR #12255:
URL: https://github.com/apache/hudi/pull/12255#discussion_r1844562503
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordGlobalLocation.java:
##########
@@ -67,8 +67,7 @@ public boolean equals(Object o) {
HoodieRecordGlobalLocation otherLoc = (HoodieRecordGlobalLocation) o;
return Objects.equals(partitionPath, otherLoc.partitionPath)
&& Objects.equals(instantTime, otherLoc.instantTime)
- && Objects.equals(fileId, otherLoc.fileId)
- && Objects.equals(position, otherLoc.position);
+ && Objects.equals(fileId, otherLoc.fileId);
Review Comment:
`HoodieGlobalSimpleIndex#tagLocationInternal` uses
`fetchRecordGlobalLocations` which put the position of records into the
`HoodieRecordGlobalLocation` instances. Such instance is later put into the
corresponding `HoodieRecord` instance if the record is an update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
