nsivabalan commented on code in PR #12269:
URL: https://github.com/apache/hudi/pull/12269#discussion_r1845557244
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -627,6 +627,10 @@ private void processDataBlock(HoodieDataBlock dataBlock,
Option<KeySpec> keySpec
*/
protected abstract void processNextDeletedRecord(DeleteRecord deleteRecord);
+ public Set<String> getDeletedRecordKeys() {
Review Comment:
wouldn't it be simpler to let only the interested concrete impl to override.
for others we just throw exception meaning, unless someone overrides and give a
concrete impl, callers may not be able to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
