the-other-tim-brown commented on code in PR #12164:
URL: https://github.com/apache/hudi/pull/12164#discussion_r1846896581
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -913,11 +913,8 @@ public String startCommit(String actionType,
HoodieTableMetaClient metaClient) {
executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient,
Option.empty()));
}
- CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
- HoodieTimeline.COMMIT_ACTION, () ->
tableServiceClient.rollbackFailedWrites());
Review Comment:
Yes, I can fix this. I will also add a unit test to assert that we only call
this path once on each of these startCommit flows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
