danny0405 commented on code in PR #12288:
URL: https://github.com/apache/hudi/pull/12288#discussion_r1847521801
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -944,13 +944,15 @@ public void startCommitWithTime(String instantTime,
String actionType) {
* Starts a new commit time for a write operation (insert/update/delete)
with specified action.
*/
private void startCommitWithTime(String instantTime, String actionType,
HoodieTableMetaClient metaClient) {
+ HoodieTableMetaClient updatedMetaClient = metaClient;
if (needsUpgradeOrDowngrade(metaClient)) {
// unclear what instant to use, since upgrade does have a given instant.
executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient,
Option.empty()));
+ updatedMetaClient = createMetaClient(true);
Review Comment:
We better update the options within `tryUpgrade`, like what we already do:
`reloadTableConfig`, `reloadActiveTimeline`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
