vinothchandar commented on code in PR #12290:
URL: https://github.com/apache/hudi/pull/12290#discussion_r1848368841
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -939,8 +939,12 @@ private void initializeFileGroups(HoodieTableMetaClient
dataMetaClient, Metadata
public void dropMetadataPartitions(List<String> metadataPartitions) throws
IOException {
for (String partitionPath : metadataPartitions) {
- // first update table config
+ // first update table config and index definitions
dataMetaClient.getTableConfig().setMetadataPartitionState(dataMetaClient,
partitionPath, false);
+ if (MetadataPartitionType.isGenericIndex(partitionPath)) {
Review Comment:
is this unit tested?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -90,6 +90,7 @@
import static org.apache.hudi.common.util.StringUtils.getUTF8Bytes;
import static org.apache.hudi.common.util.ValidationUtils.checkArgument;
import static org.apache.hudi.common.util.ValidationUtils.checkState;
+import static
org.apache.hudi.index.functional.HoodieFunctionalIndex.SPARK_IDENTITY;
Review Comment:
why is this called `SPARK_IDENTITY` .. and in `hudi-common`.. this module
must be strictly engine free
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
