lokeshj1703 commented on code in PR #12280:
URL: https://github.com/apache/hudi/pull/12280#discussion_r1850099690
##########
hudi-common/src/main/java/org/apache/hudi/common/model/WriteOperationType.java:
##########
@@ -123,6 +123,10 @@ public static boolean isOverwrite(WriteOperationType
operationType) {
return operationType == INSERT_OVERWRITE || operationType ==
INSERT_OVERWRITE_TABLE;
}
+ public boolean isOverwriteOrDeletePartition() {
Review Comment:
Addressed
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java:
##########
@@ -157,7 +157,7 @@ protected final void
writeTableMetadata(HoodieRestoreMetadata metadata) {
*/
protected final void dropIndexOnRestore() {
for (String partitionPath :
table.getMetaClient().getTableConfig().getMetadataPartitions()) {
- if (MetadataPartitionType.shouldDeletePartitionOnRestore(partitionPath))
{
+ if
(MetadataPartitionType.shouldDeleteMDTPartitionOnOverwriteOrRestore(partitionPath))
{
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
