linliu-code commented on code in PR #12312:
URL: https://github.com/apache/hudi/pull/12312#discussion_r1852946720
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieKeyLocationFetchHandle.java:
##########
@@ -53,7 +54,7 @@ public HoodieKeyLocationFetchHandle(HoodieWriteConfig config,
HoodieTable<T, I,
private List<Pair<HoodieKey, Long>>
fetchRecordKeysWithPositions(HoodieBaseFile baseFile) {
FileFormatUtils fileFormatUtils =
HoodieIOFactory.getIOFactory(hoodieTable.getStorage())
.getFileFormatUtils(baseFile.getStoragePath());
- if (keyGeneratorOpt.isPresent()) {
+ if (keyGeneratorOpt.isPresent() &&
baseFile.getStoragePath().getName().contains(HoodieFileFormat.PARQUET.getFileExtension()))
{
Review Comment:
I realized that this may cause issue by this, since parquet and orc should
use or no use the keygen at the same time. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
