codope commented on code in PR #12312:
URL: https://github.com/apache/hudi/pull/12312#discussion_r1853320904
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/OrcUtils.java:
##########
@@ -135,14 +113,37 @@ public List<Pair<HoodieKey, Long>>
fetchRecordKeysWithPositions(HoodieStorage st
return hoodieKeysAndPositions;
}
- @Override
- public List<Pair<HoodieKey, Long>>
fetchRecordKeysWithPositions(HoodieStorage storage, StoragePath filePath,
Option<BaseKeyGenerator> keyGeneratorOpt) {
Review Comment:
why is this removed? Do we support record position encoding in ORC now?
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/common/util/ParquetUtils.java:
##########
@@ -495,7 +495,7 @@ private static BigDecimal extractDecimal(Object val,
DecimalMetadata decimalMeta
* An iterator that can apply the given function {@code func} to transform
records
* from the underneath record iterator to hoodie keys.
*/
- private static class HoodieKeyIterator implements
ClosableIterator<HoodieKey> {
+ public static class HoodieKeyIterator implements ClosableIterator<HoodieKey>
{
Review Comment:
let's move it to superclass `FileFormatUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
