jonvex commented on code in PR #12310:
URL: https://github.com/apache/hudi/pull/12310#discussion_r1854901182


##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -367,6 +367,7 @@ public static Map<String, HoodieData<HoodieRecord>> 
convertMetadataToRecords(Hoo
                                                                                
boolean isColumnStatsIndexEnabled,
                                                                                
int columnStatsIndexParallelism,
                                                                                
List<String> targetColumnsForColumnStatsIndex,
+                                                                               
int maxColsToIndex,

Review Comment:
   We need the schema, and there is stuff with Lazy<Schema> maybe it is an over 
optimization? If we can get the schema at the higher layer we can just do it 
there but idk this code well if it's ok to make that change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to