linliu-code commented on code in PR #12323:
URL: https://github.com/apache/hudi/pull/12323#discussion_r1857347331
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java:
##########
@@ -443,12 +443,6 @@ private Dataset<Row>
readRecordsForGroupAsRow(JavaSparkContext jsc,
.toArray(StoragePath[]::new);
HashMap<String, String> params = new HashMap<>();
- if (hasLogFiles) {
- params.put("hoodie.datasource.query.type", "snapshot");
- } else {
- params.put("hoodie.datasource.query.type", "read_optimized");
- }
Review Comment:
https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/DefaultSource.scala#L250,
which shows there is no default value set.
I did not know if it is safe to rely the default value either.
Meanwhile, do we know how `HadoopFSRelation` ensure no performance
degradation for base file-only cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
