zhuanshenbsj1 commented on code in PR #12277:
URL: https://github.com/apache/hudi/pull/12277#discussion_r1857746806
##########
hudi-spark-datasource/hudi-spark3-common/src/main/scala/org/apache/spark/sql/hudi/command/AlterTableCommand.scala:
##########
@@ -265,7 +265,7 @@ object AlterTableCommand extends Logging {
val commitActionType =
CommitUtils.getCommitActionType(WriteOperationType.ALTER_SCHEMA,
metaClient.getTableType)
val instantTime = client.createNewInstantTime()
- client.startCommitWithTime(instantTime, commitActionType)
+ client.startAlterTableWithTime(instantTime, commitActionType)
Review Comment:
> There is no need to introduce new APIs in base write client, just use
`startCommit` should be fine. And it's not for clean but for rollback of failed
writes.
>
> Usually we have concurrent modifications to one table tween Flink pipeline
and this alter table job, one solution is to config the rollback of failed
writes as lazy, but fix here to remove the rollback should also be feasible.
Alter table will involve rollback, clean, and archive, modify the paras
will reduce the intrusiveness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
