danny0405 commented on code in PR #12343:
URL: https://github.com/apache/hudi/pull/12343#discussion_r1861409255
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkTaskContextSupplier.java:
##########
@@ -90,4 +120,16 @@ public Option<String> getProperty(EngineProperty prop) {
throw new HoodieException("Unknown engine property :" + prop);
}
+ // This reader context is used to read records before write, like
compaction, clustering.
+ @Override
+ public Option<HoodieReaderContext> getReaderContext(HoodieTableMetaClient
metaClient, boolean useReaderContext) {
+ if (useReaderContext && parquetReaderOpt.isPresent()) {
+ return Option.of(new SparkFileFormatInternalRowReaderContext(
Review Comment:
I didn't see why the reader context is bind to the task context supplier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
