lokeshj1703 commented on code in PR #12349:
URL: https://github.com/apache/hudi/pull/12349#discussion_r1861798353
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/command/index/TestSecondaryIndex.scala:
##########
@@ -92,7 +92,15 @@ class TestSecondaryIndex extends HoodieSparkSqlTestBase {
Seq("record_index", "record_index", "")
)
- spark.sql(s"create index idx_name on $tableName using
secondary_index(name)")
+ // Secondary index can not be created for two columns at once
+ checkException(s"create index idx_name_price on $tableName using
secondary_index(name,price)")(
Review Comment:
Yes, we have covered those scenarios in TestSecondaryIndex(Test
Create/Show/Drop Secondary Index),
TestSecondaryIndexPruning(testCreateAndDropSecondaryIndex), TestExpressionIndex
(Test Drop Expression Index) and TestIndexSyntax(Test Create/Drop/Show/Refresh
Index, Test Create and Drop Index Syntax with Simple record key, Test Create
and Drop Index Syntax with Complex record key.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -473,9 +473,9 @@ case class HoodieFileIndex(spark: SparkSession,
private def validateConfig(): Unit = {
if (isDataSkippingEnabled && (!isMetadataTableEnabled || !isIndexEnabled))
{
- logWarning("Data skipping requires both Metadata Table and at least one
of Column Stats Index, Record Level Index, or Functional Index" +
+ logWarning("Data skipping requires both Metadata Table and at least one
of Column Stats Index, Record Level Index, or Expression Index" +
Review Comment:
This is just a warning log. This is basically checking if column stats is
available in the table.
I have renamed the function from `isIndexEnabled` to `isIndexAvailable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
