codope commented on code in PR #12371:
URL: https://github.com/apache/hudi/pull/12371#discussion_r1863752014
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -3421,6 +3421,17 @@ private void autoAdjustConfigsForConcurrencyMode(boolean
isLockProviderPropertyS
HoodieLockConfig.LOCK_PROVIDER_CLASS_NAME.key(),
InProcessLockProvider.class.getName()));
}
+ // for a single writer scenario, with all table services inline, lets
set InProcessLockProvider
+ if (writeConfig.getWriteConcurrencyMode() ==
WriteConcurrencyMode.SINGLE_WRITER && !writeConfig.areAnyTableServicesAsync()) {
+ if (writeConfig.getLockProviderClass() != null) {
+ // add logs only when explicitly overridden by the user.
+ LOG.warn(String.format("For a single writer mode, overriding lock
provider class (%s) to %s. So, user configured lock provider %s may not take
effect",
Review Comment:
Should it be a warning? Will come up a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
