nsivabalan commented on code in PR #12343:
URL: https://github.com/apache/hudi/pull/12343#discussion_r1863953947
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -807,6 +807,15 @@ public class HoodieWriteConfig extends HoodieConfig {
.withDocumentation("Avro schema of the partial updates. This is
automatically set by the "
+ "Hudi write client and user is not expected to manually change the
value.");
+ public static final ConfigProperty<String>
TABLE_SERVICES_USE_FILE_GROUP_READER = ConfigProperty
+ .key("hoodie.table.services.use.file.group.reader")
+ .defaultValue("true")
+ .markAdvanced()
+ .sinceVersion("1.0.0")
+ .withDocumentation("Avro schema of the partial updates. This is
automatically set by the "
Review Comment:
why is this a top level config?
why would user disable new FG reader only for table services? and no for
others.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -807,6 +807,15 @@ public class HoodieWriteConfig extends HoodieConfig {
.withDocumentation("Avro schema of the partial updates. This is
automatically set by the "
+ "Hudi write client and user is not expected to manually change the
value.");
+ public static final ConfigProperty<String>
TABLE_SERVICES_USE_FILE_GROUP_READER = ConfigProperty
+ .key("hoodie.table.services.use.file.group.reader")
+ .defaultValue("true")
+ .markAdvanced()
+ .sinceVersion("1.0.0")
+ .withDocumentation("Avro schema of the partial updates. This is
automatically set by the "
Review Comment:
fix documentation ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
