bvaradar commented on a change in pull request #2048:
URL: https://github.com/apache/hudi/pull/2048#discussion_r493002158
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/view/IncrementalTimelineSyncFileSystemView.java
##########
@@ -251,6 +262,28 @@ private void addRollbackInstant(HoodieTimeline timeline,
HoodieInstant instant)
LOG.info("Done Syncing rollback instant (" + instant + ")");
}
+ /**
+ * Add newly found REPLACE instant.
+ *
+ * @param timeline Hoodie Timeline
+ * @param instant REPLACE Instant
+ */
+ private void addReplaceInstant(HoodieTimeline timeline, HoodieInstant
instant) throws IOException {
Review comment:
Discussed with @satishkotha. We will track commit action type along with
instant since we have introduced one another type of "commit" -> replace.
Restore can perform custom handling only for this action type. It is safer to
let Incremental file-system view to revert replace mappings (in memory or
rocksdb) by providing the replace instant time as it isrobust in case of
partial restore failures.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
