codope commented on code in PR #12392:
URL: https://github.com/apache/hudi/pull/12392#discussion_r1866574614
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieStreamingSink.scala:
##########
@@ -45,7 +44,6 @@ import java.util.function.{BiConsumer, Function}
import scala.collection.JavaConverters._
import scala.util.{Failure, Success, Try}
-// TODO(yihua): handle V1/V2 checkpoint
Review Comment:
@yihua My underrstanding is we don't need checkpoint translation here. This
particular Hudi sink could be a source for another Hudi table, however, in that
case checkpoint translation handled in `HoodieStreamSourceV1` or
`HoodieStreamSourceV1` will kick in when fetching from this sink and right data
will be pulled. Only, requirement is that users in silver layer, set the
correct `INCREMENTAL_READ_TABLE_VERSION`. Once all bronze is upgrade, they can
remove the override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
