the-other-tim-brown commented on code in PR #12272:
URL: https://github.com/apache/hudi/pull/12272#discussion_r1866761614
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestSimpleConcurrentFileWritesConflictResolutionStrategy.java:
##########
@@ -412,6 +412,7 @@ public void testConcurrentWritesWithPendingInstants()
throws Exception {
// make sure c3 has conflict with C1,C11,C12,C4;
HoodieCommitMetadata currentMetadata =
createCommitMetadata(currentWriterInstant, "file-2");
timeline.reload();
+ metaClient.reloadActiveTimeline();
List<HoodieInstant> completedInstantsDuringCurrentWriteOperation =
TransactionUtils
Review Comment:
`timeline.reload()` will return a new object, so this line isn't really
doing anything since the returned instance is not used. I have removed the
`timeline.reload()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
