jonathanc-n commented on code in PR #124:
URL: https://github.com/apache/hudi-rs/pull/124#discussion_r1868692161
##########
crates/core/src/table/partition.rs:
##########
@@ -196,21 +198,17 @@ pub struct PartitionFilter {
}
impl TryFrom<((&str, &str, &str), &Schema)> for PartitionFilter {
- type Error = anyhow::Error;
+ type Error = crate::Error;
fn try_from((filter, partition_schema): ((&str, &str, &str), &Schema)) ->
Result<Self> {
let (field_name, operator_str, value_str) = filter;
- let field: &Field = partition_schema
- .field_with_name(field_name)
- .with_context(|| format!("Field '{}' not found in partition
schema", field_name))?;
+ let field: &Field = partition_schema.field_with_name(field_name)?;
- let operator = Operator::from_str(operator_str)
- .with_context(|| format!("Unsupported operator: {}",
operator_str))?;
+ let operator = Operator::from_str(operator_str)?;
Review Comment:
I think we should implement a cast error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
