zhangyue19921010 commented on code in PR #12407:
URL: https://github.com/apache/hudi/pull/12407#discussion_r1868858025
##########
rfc/rfc-60/rfc-60.md:
##########
@@ -84,23 +119,85 @@ public interface HoodieStorageStrategy extends
Serializable {
/**
* Return a storage location for the given filename.
*
- * @param fileId data file ID
+ * @param path fileName
Review Comment:
> Also could you help me understand why instantTime is needed in this API by
adding it to the comment?
The instantTime is a necessary hint for HoodieCacheLayerStorageStrategy to
determine whether the current data should be written to/coming from the cache
layer or the persistent layer. Therefore, it needs to be passed in. Similarly,
HoodieObjectStorageStrategy might require fileID. I thought about it and maybe
we can abstract this into a map. Different strategies might need different
hints, so we can pass them all into the map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
